Fix: update getBaseDir to use process.cwd() for appPath#82
Merged
harshithad0703 merged 2 commits intodevelopmentfrom Jun 26, 2025
Merged
Fix: update getBaseDir to use process.cwd() for appPath#82harshithad0703 merged 2 commits intodevelopmentfrom
harshithad0703 merged 2 commits intodevelopmentfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the getBaseDir function to use process.cwd() instead of deriving the application path from __dirname.
- Updates appPath computation in getBaseDir to use process.cwd()
- Simplifies the way the base directory is determined
Comments suppressed due to low confidence (1)
src/utils.ts:73
- Switching to process.cwd() may lead to unexpected behavior if the current working directory is not the application root. Consider adding a comment to clarify that process.cwd() is intentionally used and state any assumptions about the runtime invocation context.
const appPath = process.cwd();
aman19K
reviewed
Jun 25, 2025
aman19K
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
version bump will be made after 1 more issue fix