Adding a Pre-Commit Hook - #334
Merged
Merged
Conversation
cs-raj
requested review from
harshithad0703 and
nadeem-cs
and removed request for
a team and
nadeem-cs
April 17, 2025 11:29
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } else if (self._type(source[key]) == 'array' && self._type(target[key]) == self._type(source[key])) { | ||
| target[key] = target[key].concat(source[key]); | ||
| } else { | ||
| target[key] = source[key]; |
Check warning
Code scanning / CodeQL
Prototype-polluting function
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 1 year ago
To fix the issue, we need to prevent prototype pollution by adding safeguards in the _merge_recursive function. Specifically:
- Block the special keys
__proto__andconstructorfrom being copied. - Ensure that only "own" properties of the
sourceobject are processed by usingObject.hasOwnProperty.
This fix will ensure that the function does not inadvertently modify Object.prototype or other sensitive objects.
Suggested changeset
1
src/core/lib/utils.js
| @@ -68,2 +68,4 @@ | ||
| for (const key in source) { | ||
| if (!Object.prototype.hasOwnProperty.call(source, key)) continue; | ||
| if (key === '__proto__' || key === 'constructor') continue; | ||
| if (self._type(source[key]) == 'object' && self._type(target[key]) == self._type(source[key])) { |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.