fix: added husky check and lock-file update#35
Merged
harshithad0703 merged 3 commits intodevelopmentfrom Mar 6, 2026
Merged
Conversation
harshithad0703
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Summary
Improves repo setup for contributors and CI: fixes Husky 9 pre-commit hook wiring, adds automatic hook installation on clone/install, upgrades jsdom with a matching Node engine, and keeps the repo clean by ignoring Husky’s internal directory.
Changes
Husky 9 & pre-commit hook
.husky/.pre-commit→.husky/pre-commitso Husky 9 correctly discovers and runs the hook (Husky 9 expects hook names without a leading dot).preparescript that runsnpx huskyandchmod +x .husky/pre-commit, so aftergit clone+npm install, Git hooks are set up and the pre-commit hook runs on commit..husky/_to.gitignore. Husky 9 creates this directory whenhuskyruns; it is not meant to be committed and will no longer show up ingit status.The pre-commit hook continues to run Talisman (secret scan) and Snyk (vulnerability scan); both must pass before a commit is allowed. Use
SKIP_HOOK=1to bypass when needed.jsdom upgrade (v20 → v23)
jsdomfrom^20.xto^23.0.0.new JSDOM(html),dom.window.document.querySelector('body'), and passing the body node tocollapse-whitespaceandhtmlToJson) relies only on stable DOM APIs and is compatible with jsdom 23.engines.nodefrom>=14.0.0to>=18.0.0to align with jsdom 23’s requirement (Node 18+).Testing
npm installin a fresh clone runsprepareand sets up.husky/_and executable.husky/pre-commit.git committriggers the pre-commit hook (Talisman + Snyk) when Talisman and Snyk are installed..husky/_or other Husky internals are committed; only.husky/pre-commitis tracked.Notes for reviewers
engines.nodebump; consider documenting this in the README if not already.