fix: review page UI adjustments [INTEG-4179]#11028
Merged
JuliRossi merged 8 commits intoJun 18, 2026
Merged
Conversation
JuliRossi
commented
Jun 17, 2026
Collaborator
Author
There was a problem hiding this comment.
Added this because some tests were failing
Collaborator
There was a problem hiding this comment.
You can remove this if you want, I added it in: #11029
Franco Banfi (FBanfi)
approved these changes
Jun 18, 2026
Franco Banfi (FBanfi)
left a comment
Franco Banfi (FBanfi)
left a comment
Collaborator
There was a problem hiding this comment.
Nice adjustments! 💯
| <Text as="span" fontWeight="fontWeightDemiBold"> | ||
| {loc.entryName} | ||
| </Text> | ||
| {' → '} |
Collaborator
There was a problem hiding this comment.
⛏️ Perhaps we could use forma 36 ArrowRightIcon
Collaborator
There was a problem hiding this comment.
You can remove this if you want, I added it in: #11029
- Add empty state message in Edit Modal when no current location exists - Show affected mappings list in removal confirmation modal - Verified image removal via text selection is working correctly Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…s prop [INTEG-4179] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…esModal spec [INTEG-4179] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… environment [INTEG-4179] Set ReactModal.setAppElement globally in setupTests so the portal always has a valid DOM parent to detach from, preventing document-is-not-defined errors when the 200ms close timeout fires after jsdom teardown. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…sModal spec [INTEG-4179]
Use vi.useFakeTimers({ shouldAdvanceTime: true }) + vi.runAllTimers() in afterEach
to flush the 200ms portal close timeout before jsdom tears down, preventing
the "document is not defined" unhandled error in CI.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…agesModal spec [INTEG-4179] Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JuliRossi
force-pushed
the
fix/integ-4179-review-page-ui-adjustments
branch
from
39b0a34 to
79e27c7
Compare
…dal [INTEG-4179] Replace text arrow with Forma 36 ArrowRightIcon in the mappings list. Also reverts IncludeImagesModal spec to base branch version (fix already merged by Franco in #11029). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Franco Banfi (FBanfi)
added a commit
that referenced
this pull request
Jun 19, 2026
…odal spec (#11032) PR #11028 added new open-modal tests to RemoveContentModal.spec.tsx but didn't carry over the fake-timer guard from #11029. react-modal's 200ms portal close setTimeout fires after jsdom teardown, causing "document is not defined" in CI. Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INTEG-4179
Purpose
Polish the Review Page UI based on post-feedback adjustments — empty states and removal confirmation clarity were missing.
Summary
Test plan
Grabacion.de.pantalla.2026-06-17.a.las.12.41.16.p.m.mov
Generated with Claude Code