Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playbooks: Restore the generation & installation of the Bash completions #1593

Commits on Nov 12, 2024

  1. playbooks: Restore the generation & installation of the Bash completions

    The package providing /usr/share/pkgconfig/bash-completion.pc changed
    from bash-completion to bash-completion-devel in Fedora 41 onwards [1].
    This meant that the Bash completions were no longer being generated and
    installed by the CI.
    
    [1] Fedora bash-completion commit d1f5dc48c0440cc6
        https://src.fedoraproject.org/rpms/bash-completion/c/d1f5dc48c0440cc6
        https://bugzilla.redhat.com/show_bug.cgi?id=1457164
    
    containers#1593
    debarshiray committed Nov 12, 2024
    Configuration menu
    Copy the full SHA
    2049199 View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. playbooks: Use pkgconfig(bash-completion) to install bash-completion.pc

    Unlike Fedora, where the package providing bash-completion.pc changed in
    Fedora 41 onwards [1,2], it hasn't changed in CentOS Stream 9.  So, this
    doesn't change the behaviour of the CI.
    
    However, the Fedora Packaging Guidelines recommend using pkgconfig(...)
    to depend on a *.pc file [3], instead of the name of the package, and
    there has been a problem on Fedora caused by not doing that.  Therefore,
    it's better to follow the guidelines for consistency and safety.
    
    [1] Fedora bash-completion commit d1f5dc48c0440cc6
        https://src.fedoraproject.org/rpms/bash-completion/c/d1f5dc48c0440cc6
        https://bugzilla.redhat.com/show_bug.cgi?id=1457164
    
    [2] Commit 2049199
        containers@204919917e4af528
    
    [3] https://docs.fedoraproject.org/en-US/packaging-guidelines/PkgConfigBuildRequires/
    
    containers#1593
    debarshiray committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c11a03c View commit details
    Browse the repository at this point in the history