Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playbooks/dependencies-centos-9-stream: Show the Bash version #1587

Conversation

debarshiray
Copy link
Member

@debarshiray debarshiray commented Nov 5, 2024

Fallout from 6626b11

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Nov 5, 2024
Ever since Toolbx 0.0.97, newly created containers no longer need the
org.freedesktop.Flatpak.SessionHelper D-Bus service [1,2].  Therefore,
there's no need for flatpak-session-helper in the CI, unless tests for
ackwards compatibility with old containers are added in future.

[1] Commit 82c32be
    containers@82c32bea742621a3
    containers#267

[2] Commit 71b5c8c
    containers@71b5c8c0a235249b
    containers#267

containers#1587
@debarshiray debarshiray force-pushed the wip/rishi/playbooks-drop-deprecated-dependencies-00 branch from 5aff6d1 to 97a9f11 Compare November 5, 2024 17:58
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Nov 5, 2024
Ever since Toolbx 0.0.97, newly created containers no longer need the
org.freedesktop.Flatpak.SessionHelper D-Bus service [1,2].  Therefore,
there's no need for flatpak-session-helper in the CI, unless tests for
backwards compatibility with old containers are added in future.

[1] Commit 82c32be
    containers@82c32bea742621a3
    containers#267

[2] Commit 71b5c8c
    containers@71b5c8c0a235249b
    containers#267

containers#1587
@debarshiray debarshiray force-pushed the wip/rishi/playbooks-drop-deprecated-dependencies-00 branch from 97a9f11 to ec2ae6b Compare November 5, 2024 17:58
@debarshiray debarshiray changed the title playbooks: Drop deprecated flatpak-session-helper playbooks: Various fixes and updates to the dependencies Nov 5, 2024
debarshiray added a commit to debarshiray/toolbox that referenced this pull request Nov 5, 2024
@debarshiray
Copy link
Member Author

Oops, I forgot that we still need flatpak-session-helper because it provides the org.freedesktop.Flatpak.Development interface that flatpak-spawn(1) uses:

not ok 223 create: Try with an invalid custom name (using positional argument, forwarded to host)
fedora-rawhide | # tags: commands-options
fedora-rawhide | # (from function `assert_line' in file test/system/libs/bats-assert/src/assert.bash, line 488,
fedora-rawhide | #  in test file test/system/501-create.bats, line 44)
fedora-rawhide | #   `assert_line --index 0 "Error: invalid argument for 'CONTAINER'"' failed
fedora-rawhide | # ~ ~/src/github.com/containers/toolbox
fedora-rawhide | #
fedora-rawhide | # -- line differs --
fedora-rawhide | # index    : 0
fedora-rawhide | # expected : Error: invalid argument for 'CONTAINER'
fedora-rawhide | # actual   : Portal call failed: The name is not activatable
fedora-rawhide | # --

I am glad we have tests!

@debarshiray debarshiray force-pushed the wip/rishi/playbooks-drop-deprecated-dependencies-00 branch from ec2ae6b to b443428 Compare November 6, 2024 00:02
@debarshiray
Copy link
Member Author

recheck

@debarshiray debarshiray changed the title playbooks: Various fixes and updates to the dependencies playbooks/dependencies-centos-9-stream: Show the Bash version Nov 6, 2024
@debarshiray debarshiray merged commit b443428 into containers:main Nov 6, 2024
3 checks passed
@debarshiray debarshiray deleted the wip/rishi/playbooks-drop-deprecated-dependencies-00 branch November 6, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant