Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Let the terminal know the active container on all host OSes #1429

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

debarshiray
Copy link
Member

Prompt is a new terminal emulation application [1] designed for a container-oriented desktop that implements the OSC 777 escape sequence to track and preserve the user's current Toolbx container [2]. Hence, Fedora's fork of GNOME Terminal is no longer the only one to offer this.

Therefore, it's time let users of all host operating systems enjoy this feature.

This reverts commits a3e8d8d and 3a96feb.

[1] https://gitlab.gnome.org/chergert/prompt

[2] https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/17

#218

Copy link

Build failed.
https://softwarefactory-project.io/zuul/t/local/buildset/cd770412fcd84ffb86ce21465cc178ac

unit-test FAILURE in 7m 02s
unit-test-migration-path-for-coreos-toolbox FAILURE in 2m 37s
unit-test-restricted FAILURE in 6m 21s
system-test-fedora-rawhide FAILURE in 30m 42s
system-test-fedora-39 FAILURE in 26m 48s
system-test-fedora-38 FAILURE in 29m 22s

@debarshiray debarshiray force-pushed the wip/rishi/issue-218-00 branch from 40eec4e to f6d1af9 Compare December 20, 2023 08:33
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/a6329956853b42998c08aaf15f855f01

✔️ unit-test SUCCESS in 6m 22s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 06s
✔️ unit-test-restricted SUCCESS in 6m 18s
✔️ system-test-fedora-rawhide SUCCESS in 28m 20s
✔️ system-test-fedora-39 SUCCESS in 26m 48s
✔️ system-test-fedora-38 SUCCESS in 28m 14s

@HarryMichal
Copy link
Member

Do we know how does this behave in non-VTE/non-patched terminal emulators? Does it change the behaviour of the emulator or is it just ignored?

@debarshiray
Copy link
Member Author

Do we know how does this behave in non-VTE/non-patched terminal emulators? Does it change the behaviour of the emulator or is it just ignored?

I believe VTE just ignores the unknown escape sequence.

This is this branch on Ubuntu 23.10 with a GNOME Terminal that doesn't preserve the current Toolbx container:

image

Prompt is a new terminal emulation application [1] designed for a
container-oriented desktop that implements the OSC 777 escape sequence
to track and preserve the user's current Toolbx container [2].  Hence,
Fedora's fork of GNOME Terminal is no longer the only one to offer this.

The implementation in Prompt is already better because it has a
user-visible setting to disable this integration with Toolbx, in case
the user doesn't want it.  Therefore, it's time to let users of all host
operating systems enjoy this feature.

This reverts commits a3e8d8d and
3a96feb.

[1] https://gitlab.gnome.org/chergert/prompt

[2] https://gitlab.freedesktop.org/terminal-wg/specifications/-/issues/17

containers#218
@debarshiray debarshiray force-pushed the wip/rishi/issue-218-00 branch from f6d1af9 to 8caa7cd Compare December 20, 2023 18:48
Copy link

Build succeeded.
https://softwarefactory-project.io/zuul/t/local/buildset/25763fc164f5463f975c4fb5566c97ec

✔️ unit-test SUCCESS in 7m 38s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 3m 30s
✔️ unit-test-restricted SUCCESS in 6m 29s
✔️ system-test-fedora-rawhide SUCCESS in 30m 24s
✔️ system-test-fedora-39 SUCCESS in 29m 45s
✔️ system-test-fedora-38 SUCCESS in 29m 48s

@debarshiray debarshiray merged commit 8caa7cd into containers:main Dec 20, 2023
2 checks passed
@debarshiray debarshiray deleted the wip/rishi/issue-218-00 branch December 20, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants