Revert "Add --network-mode option"

[ericcurtin]

Reverts #674

Summary by Sourcery

Bug Fixes:

• Restore the default network mode behavior for all commands.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request reverts the addition of the --network-mode option from the ramalama CLI tool. This includes removing the argument from the CLI subcommands, the build process, and the documentation.

Class diagram showing CLI argument removals

classDiagram
    class ArgumentParser {
        -arguments
        +add_argument()
        +set_defaults()
    }

    class BenchParser {
        +setup_parser()
    }
    class ConvertParser {
        +setup_parser()
    }
    class RunParser {
        +setup_parser()
    }
    class ServeParser {
        +setup_parser()
    }

    BenchParser --|> ArgumentParser : uses
    ConvertParser --|> ArgumentParser : uses
    RunParser --|> ArgumentParser : uses
    ServeParser --|> ArgumentParser : uses

    note for BenchParser "Removed --network-mode"
    note for ConvertParser "Removed --network-mode"
    note for RunParser "Removed --network-mode"
    note for ServeParser "Removed --network-mode"

Loading

File-Level Changes

Change	Details	Files
Removed the --network-mode argument from the CLI subcommands.	Removed --network-mode argument from bench_parser. Removed --network-mode argument from convert_parser. Removed --network-mode argument from run_parser. Removed --network-mode argument from serve_parser.	ramalama/cli.py
Removed the --network-mode parameter from the build command.	Removed f'--network={args.network_mode}' from the podman build command.	ramalama/oci.py
Removed documentation for the --network-mode option.	Removed the --network-mode option from ramalama-bench.1.md. Removed the --network-mode option from ramalama-convert.1.md. Removed the --network-mode option from ramalama-run.1.md. Removed the --network-mode option from ramalama-serve.1.md.	docs/ramalama-bench.1.md docs/ramalama-convert.1.md docs/ramalama-run.1.md docs/ramalama-serve.1.md
Removed the --network parameter from the setup_container function.	Removed f'--network={args.network_mode}' from the podman create command.	ramalama/model.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• Please provide the rationale for reverting the network mode configuration options. This removes potentially useful security controls - was there a specific issue that prompted this revert?

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

Why?