Update progress bar only once every 100ms

[ericcurtin]

To help with CPU usage

Summary by Sourcery

Enhancements:

• Limit progress bar updates to once every 100ms.

[sourcery-ai]

Reviewer's Guide by Sourcery

The progress bar update was changed to only update every 100ms to reduce CPU usage.

Sequence diagram for throttled progress bar updates

sequenceDiagram
    participant Client
    participant ProgressBar
    loop Every data chunk
        Client->>Client: Read 1024 bytes
        Client->>Client: Check time elapsed
        alt >100ms since last update
            Client->>ProgressBar: Update progress
            Note right of ProgressBar: Progress updated
        else <100ms since last update
            Note right of Client: Skip update
        end
    end

Loading

State diagram for progress bar update logic

stateDiagram-v2
    [*] --> ReadingData
    ReadingData --> CheckTime: Read 1024 bytes
    CheckTime --> UpdateProgress: >100ms elapsed
    CheckTime --> ReadingData: <100ms elapsed
    UpdateProgress --> ReadingData
    ReadingData --> [*]: No more data

Loading

File-Level Changes

Change	Details	Files
The progress bar update was changed to only update every 100ms.	Added a last_update_time variable to track the last time the progress bar was updated. Added a check to see if 100ms has passed since the last update before updating the progress bar.	ramalama/http_client.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• The progress tracking needs to accumulate all bytes downloaded since the last update, not just the last chunk. Currently it only passes the most recent chunk size to update_progress(), which will make the progress reporting inaccurate when throttled.

Here's what I looked at during the review

• 🟡 General issues: 1 issue found
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[maxamillion]

+1 LGTM

[rhatdan]

@ericcurtin waiting for you to update based on Sorcery update. Otherwise merge.

[ericcurtin]

This is ready @rhatdan @maxamillion @jhjaggars