-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README: add macOS steps #669
base: main
Are you sure you want to change the base?
Conversation
Let's make user live easier to join the ramalama club. Signed-off-by: Douglas Schilling Landgraf <[email protected]>
Reviewer's Guide by SourceryThis pull request adds a guide for running the ramalama project on macOS. It includes instructions for installing necessary tools and setting up the environment. Flow diagram for macOS installation stepsflowchart TD
A[Start Installation] --> B[Install Dependencies]
B --> C[Install Go]
B --> D[Install Podman]
B --> E[Install go-md2man]
C & D & E --> F[Setup Python Environment]
F --> G[Create Virtual Environment]
G --> H[Activate Virtual Environment]
H --> I[Install argcomplete]
I --> J[Run make install]
J --> K[Setup Podman]
K --> L[Initialize Podman machine]
L --> M[Start Podman machine]
M --> N[Build Project]
N --> O[Installation Complete]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @dougsland - I've reviewed your changes - here's some feedback:
Overall Comments:
- The installation steps appear to be in a suboptimal order - 'sudo make install' should typically come after 'sudo make build'. Consider reordering these steps.
- Consider adding prerequisites and system requirements to the macOS guide (e.g., minimum macOS version, required disk space, etc).
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
||
```bash | ||
brew install go | ||
brew install podman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be much simpler than this, install podman cli or podman desktop for macOS here:
this official installer comes with krunkit for AI acceleration, etc. I'd avoid recommending brew podman, it's not as good.
Change the hypervisor to krunkit. Run podman machine init, podman machine start, etc.
Then run:
curl -fsSL https://raw.githubusercontent.com/containers/ramalama/s/install.sh | bash
The "curl" command is the only one you strictly need if you don't want to use containers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. brew install podman
is not recomended. Link to installation of podman desktop and recommend libkrun
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also podman should be optional, Docker is an option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes I wish RamaLama was just part of podman desktop and podman cli installers. It's like 10 python files? Super tiny...
Let's make user live easier to join the ramalama club.
Summary by Sourcery
Add instructions for running ramalama on macOS.
New Features:
Documentation: