Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looks like RHEL9 doesn't support autochangelog #560

Closed
wants to merge 1 commit into from

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 9, 2025

Change back to manual changelogs

Summary by Sourcery

Build:

  • Generate changelogs manually instead of automatically.

Copy link
Contributor

sourcery-ai bot commented Jan 9, 2025

Reviewer's Guide by Sourcery

This pull request reverts the changelog generation method from automatic to manual. This change was made due to RHEL9 incompatibility with the automatic changelog generation tool.

State diagram for changelog generation process change

stateDiagram-v2
    [*] --> AutomaticChangelog: Initial State
    AutomaticChangelog --> ManualChangelog: RHEL9 Incompatibility
    ManualChangelog --> [*]

    state ManualChangelog {
        [*] --> AddEntry
        AddEntry --> FormatEntry: Add timestamp, author, version
        FormatEntry --> [*]
    }
Loading

File-Level Changes

Change Details Files
Revert to manual changelog generation
  • Removed the %autochangelog line from the spec file.
  • Added manual changelog entries for previous releases and updates.
  • Updated version numbers and release dates in the changelog entries to reflect the manual entries.
rpm/python-ramalama.spec

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ericcurtin
Copy link
Collaborator Author

If my reading of the build failures are correct on the main branch, RHEL9 doesn't support autochangelog, EPEL9 seems to though

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide a more detailed commit message explaining why autochangelog needs to be disabled (e.g., RHEL9 compatibility requirements)
  • Consider using conditional logic to only disable autochangelog for RHEL9 builds while maintaining it for other distributions that support it
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Change back to manual changelogs

Signed-off-by: Eric Curtin <[email protected]>
@rhatdan
Copy link
Member

rhatdan commented Jan 9, 2025

@lsm5 @smooge PTAL

@ericcurtin
Copy link
Collaborator Author

@lsm5 could we get centos-stream-9 packit builds turned on for PRs so we don't get into the scenario where main is failing but PRs are passing again?

@maxamillion
Copy link
Collaborator

@ericcurtin it looks like another option would be that we could add the epel repos to the UBI base image and install the rpmautospec-rpm-macros package which provides the %autochangelog macro.

@ericcurtin
Copy link
Collaborator Author

ericcurtin commented Feb 4, 2025

@ericcurtin it looks like another option would be that we could add the epel repos to the UBI base image and install the rpmautospec-rpm-macros package which provides the %autochangelog macro.

Yeah I guess I'm more worried if we end up packaging this for RHEL at some point. But we can close this for now and re-visit that in future if we need to in future.

@lsm5 or @maxamillion maybe we just turn off the centos-stream-9 builds on the main branch of ramalama for now to get it green again? And only build on EPEL9, not a Packit expert personally.

@maxamillion
Copy link
Collaborator

@ericcurtin sounds like the RHEL problem, not an upstream one 😉

@ericcurtin
Copy link
Collaborator Author

Yeah I guess, closing... @lsm5 or @lbarcziova how do we turn off centos-stream-9 builds on the main branch here in packit? We've been red since forever

@ericcurtin ericcurtin closed this Feb 4, 2025
@ericcurtin ericcurtin deleted the manual-changelogs branch February 4, 2025 17:59
@lbarcziova
Copy link

hi @ericcurtin ! Currently, for the main branch, the builds are implicitly submitted for all the targets in the rhcontainerbot/podman-next Copr repo. If you want to override this, you need to define the targets list in here, similarly like you have it defined for pull-requests here.

@ericcurtin
Copy link
Collaborator Author

Thank you @lbarcziova

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants