-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove huggingface warning #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request removes the warning about huggingface-cli not being available by removing the check for huggingface-cli and the associated warning message. Class diagram showing the removal of huggingface-cli checkclassDiagram
class HuggingFaceModel {
-String model
-String directory
-String filename
-Boolean hf_cli_available (removed)
+login(args)
}
note for HuggingFaceModel "Removed hf_cli_available check"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @ericcurtin - I've reviewed your changes - here's some feedback:
Overall Comments:
- This change will cause a NameError in the login method since self.hf_cli_available is used but no longer initialized. Please either remove all huggingface-cli dependencies or keep the availability check.
- Please provide a more detailed explanation of why this change is needed and how it improves the codebase.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ericcurtin
force-pushed
the
warning
branch
2 times, most recently
from
January 7, 2025 13:06
d831da2
to
5495ff0
Compare
It prints on all usages of huggingface, it's ugly. We don't really need huggingface-cli for most usages of hf, this suggests we do. Signed-off-by: Eric Curtin <[email protected]>
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It prints on all usages of huggingface, it's ugly.
We don't really need huggingface-cli for most usages of hf, this suggests we do.
Summary by Sourcery
Remove the warning about the huggingface CLI not being available.
Bug Fixes:
Enhancements: