Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update llama.cpp to get context size fix #538

Merged
merged 1 commit into from
Jan 7, 2025
Merged

Update llama.cpp to get context size fix #538

merged 1 commit into from
Jan 7, 2025

Conversation

ericcurtin
Copy link
Collaborator

@ericcurtin ericcurtin commented Jan 7, 2025

Also update whisper.cpp while we are at it.

Summary by Sourcery

Update llama.cpp and whisper.cpp to their latest versions.

Build:

  • Update llama.cpp to a4dd490069a66ae56b42127048f06757fc4de4f7.
  • Update whisper.cpp to 8a9ad7844d6e2a10cddf4b92de4089d7ac2b14a9.

Also update whisper.cpp while we are at it.

Signed-off-by: Eric Curtin <[email protected]>
Copy link
Contributor

sourcery-ai bot commented Jan 7, 2025

Reviewer's Guide by Sourcery

This pull request updates the llama.cpp and whisper.cpp libraries to their latest versions to include a fix for the context size issue.

Sequence diagram for build script update process

sequenceDiagram
    participant BS as Build Script
    participant Git
    participant WC as whisper.cpp
    participant LC as llama.cpp

    BS->>Git: Clone whisper.cpp
    Git-->>BS: Repository cloned
    BS->>WC: Checkout new SHA (8a9ad78)
    Note over WC: Updated from 3de9dea

    BS->>Git: Clone llama.cpp
    Git-->>BS: Repository cloned
    BS->>LC: Checkout new SHA (a4dd490)
    Note over LC: Updated from 0827b2c
Loading

File-Level Changes

Change Details Files
Update llama.cpp to fix context size
  • Updated the llama.cpp commit SHA from 0827b2c1da299805288abbd556d869318f2b121e to a4dd490069a66ae56b42127048f06757fc4de4f7
container-images/scripts/build_llama_and_whisper.sh
Update whisper.cpp
  • Updated the whisper.cpp commit SHA from 3de9deead5759eb038966990e3cb5d83984ae467 to 8a9ad7844d6e2a10cddf4b92de4089d7ac2b14a9
container-images/scripts/build_llama_and_whisper.sh

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Please provide more detail in the commit message about why these specific versions were chosen. What context size fix does the llama.cpp update address? Why was whisper.cpp updated?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ericcurtin
Copy link
Collaborator Author

@rhatdan
Copy link
Member

rhatdan commented Jan 7, 2025

LGTM

@rhatdan rhatdan merged commit e1445ab into main Jan 7, 2025
12 checks passed
@ericcurtin ericcurtin deleted the update branch January 7, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants