Attempt to use versioned container

[ericcurtin]

Check if it's locally available, then try and pull. Then just use latest if it's not available.

Summary by Sourcery

Enhancements:

• Attempt to use a versioned container if it exists locally or can be pulled.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces versioned containers to improve reproducibility and dependency management. It modifies the model.py and common.py files to attempt using a versioned container if available. If the versioned container image is not found locally, it attempts to pull it. If the pull fails, it defaults to using the "latest" tag.

Sequence diagram for container version resolution

sequenceDiagram
    participant C as Container Manager
    participant M as Model
    participant R as Registry

    M->>C: inspect versioned image
    alt Image exists locally
        C-->>M: Success
    else Image not found locally
        M->>C: pull versioned image
        C->>R: pull image
        alt Pull successful
            R-->>C: Image downloaded
            C-->>M: Success
        else Pull failed
            R-->>C: Error
            C-->>M: Failure
            Note over M: Fallback to latest tag
        end
    end

Loading

Class diagram showing updated Model class

classDiagram
    class Model {
        +remove(args)
        +attempt_to_use_versioned(conman, image, vers, args) bool
        -_image(args) str
        +setup_container(args)
    }
    note for Model "New method attempt_to_use_versioned
handles versioned container resolution"

Loading

State diagram for container version resolution process

stateDiagram-v2
    [*] --> CheckLocal
    CheckLocal --> UseVersioned: Version exists locally
    CheckLocal --> AttemptPull: Version not found
    AttemptPull --> UseVersioned: Pull successful
    AttemptPull --> UseLatest: Pull failed
    UseVersioned --> [*]
    UseLatest --> [*]

Loading

File-Level Changes

Change	Details	Files
Added logic to attempt using a versioned container image.	Added the attempt_to_use_versioned function to check for and pull a versioned container image. Modified the _image function to use the versioned image if available, falling back to the "latest" tag if not.	ramalama/model.py
Modified run_cmd function to handle ignoring all output.	Added the ignore_all parameter to the run_cmd function to suppress all output if set. Modified the run_cmd function to use subprocess.DEVNULL for stdout and stderr if ignore_all is True.	ramalama/common.py
Modified default image name.	Removed the ":latest" tag from the default image name in the default_image function, allowing the model.py logic to handle versioning.	ramalama/common.py

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @ericcurtin - I've reviewed your changes - here's some feedback:

Overall Comments:

• The broad Exception catch in attempt_to_use_versioned could mask important errors. Consider catching specific exceptions (like ContainerError or NetworkError) that you expect might occur.

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟡 Complexity: 1 issue found
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[rhatdan]

No elif required here, just return it.

[ericcurtin]

Will do!

[rhatdan]

LGTM once tests pass.

[ericcurtin]

Part of me wishes we prepared vLLM and llama.cpp Containerfiles and upstreamed these Containerfiles to both projects specifically, so we would have UBI-based images published by both projects. At least CUDA ones (and maybe ROCm, etc.).

Both projects publish their own images but they are debian/ubuntu-based I believe.

Maybe they would be willing to publish :ubi9-cuda images alongside the debian/ubuntu ones.

[rhatdan]

Needs a rebase.

[rhatdan]

LGTM