Skip to content

Conversation

podmanbot
Copy link
Collaborator

None

Signed-off-by: ashley-cui <[email protected]>
@ashley-cui
Copy link
Member

LGTM

Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2025
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, podmanbot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2025
@Luap99
Copy link
Member

Luap99 commented Oct 1, 2025

Btw do we really gain anything with these PRs other than pointless churn for us? To be clear I only mean bumping -dev on patch releases on the release branch, I definitely want to have the minor -dev bump on main.
cc @mheon

@mheon
Copy link
Member

mheon commented Oct 1, 2025

IMO, they're valuable because they tell us someone is running tip of branch vs stable tag. We don't get many people doing that on release branches, but it still seems nice to be alerted when it happens

@Luap99
Copy link
Member

Luap99 commented Oct 1, 2025

IMO, they're valuable because they tell us someone is running tip of branch vs stable tag. We don't get many people doing that on release branches, but it still seems nice to be alerted when it happens

Well how often would that happen AND actually matter? We have solid CI and on a release branch especially any commit should be good and ready to be releases any time. Why would it matter for debugging if they run release x.y.z or release x.y.z + a few more backported commits, the issue is likely not related to them doing that. And practically speaking any user who build podman can patch it regardless without us noticing. Many distro builds are patched to some level of degree.

All I am complaining about is that I have to look at this PR that doesn't add any meaningful value in my eyes and I have to keep pressing rerun here due the flakes (I know something we must address regardless)

@TomSweeneyRedHat
Copy link
Member

FWIW, I'm not a fan of -dev versions in devoted release branches. But that's just my $.02.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants