Add artifact quadlet unit type support #26624
Conversation
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Odilhao The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Odilhao
force-pushed
the
artifact-quadlet-implementation
branch
4 times, most recently
from
304daa3 to
96aeafe
Compare
RFE: Add artifact quadlet unit type containers#25778 Signed-off-by: Odilon Sousa <[email protected]>
Odilhao
force-pushed
the
artifact-quadlet-implementation
branch
from
96aeafe to
206628c
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
openshift-ci
bot
added
release-note
and removed
do-not-merge/release-note-label-needed
There was a problem hiding this comment.
Thanks for the contribution.
OK for the code. Some comments about the documentation and supporting non-existing flags.
As for tests, first, they are not being called, you need to add them to https://github.com/containers/podman/blob/main/test/e2e/quadlet_test.go.
In addition, add a test case that involves a dependency where a container mounts an artifact pulled via an .artifact unit (see this:
podman/test/e2e/quadlet_test.go
Line 1169 in ffcd197
| ### WARNING: Experimental Unit | ||
|
|
||
| This unit is considered experimental and still in development. Inputs, options, and outputs are all subject to change. |
There was a problem hiding this comment.
Why is that? Is it because podman artifact is at this state?
There was a problem hiding this comment.
Yes, I just added the same text from the artifact section in podman
|
|
||
| | **[Artifact] options** | **podman artifact equivalent** | | ||
| |---------------------------------------------|--------------------------------------------------------| | ||
| | Arch=aarch64 | --arch=aarch64 | |
There was a problem hiding this comment.
Looking at the code for podma artifact pull, I don't see the support for the following flags
archosvariantpolicy
|
|
||
| Using artifact units allows containers to depend on artifacts being automatically pulled. This is | ||
| particularly useful for managing artifacts that containers need to mount or access. | ||
|
|
There was a problem hiding this comment.
You should mention that the Artifact key is required
|
|
||
| Valid options for `[Artifact]` are listed below: | ||
|
|
||
| | **[Artifact] options** | **podman artifact equivalent** | |
There was a problem hiding this comment.
Shouldn't this be podman artifact pull equivalent?
| @@ -2179,6 +2306,14 @@ IPRange=172.16.0.0/28 | |||
| Label=org.test.Key=value | |||
| ``` | |||
|
|
|||
| Example `test.artifact`: | |||
There was a problem hiding this comment.
Please also add a usage example. Where would test.artifact be used?
RFE: Add artifact quadlet unit type #25778
Does this PR introduce a user-facing change?
Yes