Fix link in rootless_tutorial.md #26562
Conversation
Signed-off-by: d2weber <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d2weber, giuseppe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
There was a problem hiding this comment.
The link works fine so what exactly is this fixing? In fact the old link pointed to the exact bullet point while the new link just link the whole document so the reader doesn't know which point was meant, no? So I don't see how the new link improves the description
do we need a permalink though? Because now we are linking to the exact line number in the main branch, that can change and the link can point to something completely unrelated without us noticing it. |
|
yeah I guess linking main is not right either. I find it weird to cross link for one sentence at all, the man page link seems sufficient already? For more info on pasta I also wrote https://blog.podman.io/2024/03/podman-5-0-breaking-changes-in-detail/ (see the pasta section) and https://blog.podman.io/2024/10/podman-5-3-changes-for-improved-networking-experience-with-pasta/ which may be better links? |
|
I think a link to your blog post is the best option |
|
@d2weber could you please amend the suggested change? |
Does this PR introduce a user-facing change?