System tests: skip checkpoint tests on Fedora Rawhide/RHEL/CentOS Stream #26319
Conversation
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
lsm5
changed the title
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
lsm5
force-pushed
the
rawhide-rhel-skip-checkpoint
branch
from
760f4d0 to
5c226fa
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
weird it's failing on rawhide env but it passes on my local rawhide. trying on manual testing farm env... |
lsm5
force-pushed
the
rawhide-rhel-skip-checkpoint
branch
2 times, most recently
from
e4dce62 to
b6cc817
Compare
|
/packit test |
lsm5
force-pushed
the
rawhide-rhel-skip-checkpoint
branch
2 times, most recently
from
3d7065a to
706fe08
Compare
openshift-ci
bot
added
the
do-not-merge/work-in-progress
lsm5
force-pushed
the
rawhide-rhel-skip-checkpoint
branch
from
af47dba to
66d9d60
Compare
These tests break all the time on said environments. Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
rawhide-rhel-skip-checkpoint
branch
from
66d9d60 to
78fe947
Compare
|
Really weird why this would fail on testing-farm rawhide env in CI, when it works on my local rawhide, manually run testing-farm instance as well as in the cirrus |
It is failing on all rawhide systems AFAICT, if it isn't on yours I guess you are using an older kernel since criu is just broken with 6.16 (not sure what the issue on centos/RHEL is) |
| # Often breaks on RHEL/CentOS Stream and Fedora Rawhide | ||
| skip_if_rhel_or_centos | ||
| skip_if_rawhide |
There was a problem hiding this comment.
This is fundamentally incorrect in my eyes.
First this should be tested on RHEL/centos in general, if this breaks there than this is highly concerning and there must be clear bug reports linked why it is skipped so QE people can unskip it once the issue is fixed. Otherwise we never catch new issues there which means they won't get fixed either.
As for rawhide there is only a single test case that fails so it should only skip that specific one.
| function is_rhel_or_centos() { | ||
| if find /etc/redhat-release && grep -Eiq "Red Hat Enterprise Linux|CentOS Stream" /etc/redhat-release; then | ||
| return 0 | ||
| fi | ||
| return 1 | ||
| } | ||
|
|
||
| function is_rawhide() { | ||
| if find /etc/fedora-release && grep -Eiq "Rawhide" /etc/fedora-release; then | ||
| return 0 | ||
| fi | ||
| return 1 | ||
| } |
There was a problem hiding this comment.
Should this be cached? Also hard coded to redhat/fedora-release seems unnecessary.
I would think the best way would be to parse /etc/os-release and then safe ID and VERSION_ID fields like done in e2e tests, i.e. GetHostDistributionInfo()?
I meant the test skip was failing in CI too, not the test itself. Anyway, I'll rework this to only be for Fedora Rawhide as that's very annoying on main PRs. I'll do rhel/centos in a separate PR. |
These tests break all the time on said environments.
Does this PR introduce a user-facing change?