Skip to content

Revert "Force use of iptables on Windows WSL" #26318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Revert "Force use of iptables on Windows WSL" #26318

wants to merge 1 commit into from

Conversation

l0rd
Copy link
Member

@l0rd l0rd commented Jun 8, 2025

This reverts commit dae1541 (because #25201 has been fixed).

Does this PR introduce a user-facing change?

None

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: l0rd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2025
@l0rd l0rd mentioned this pull request Jun 8, 2025
Open
@packit-as-a-service Packit-as-a-Service
Copy link

[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore.

@l0rd l0rd added the No New Tests Allow PR to proceed without adding regression tests label Jun 9, 2025
Luap99
Luap99 reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off is missing.

Now thinking about this are we already in a position to drop this? Are we only supporting the latest wsl version? What about users who didn't update yet?
Obviously I am in favour of using nftables just wondering if it makes sense to maybe wait a release cycle more? I guess this would only be released in August so maybe two months are already enough.

@l0rd
Copy link
Member Author

l0rd commented Jun 10, 2025

Now thinking about this are we already in a position to drop this? Are we only supporting the latest wsl version? What about users who didn't update yet?
Obviously I am in favour of using nftables just wondering if it makes sense to maybe wait a release cycle more? I guess this would only be released in August so maybe two months are already enough.

This is a good point. I think it would be better to continue configuring iptables if the version of WSL is 2.5.7 or lower.

@l0rd l0rd marked this pull request as draft June 16, 2025 15:57
@l0rd l0rd marked this pull request as draft June 16, 2025 15:57
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Luap99 Luap99 Luap99 left review comments

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. machine No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0rd @Luap99