feat: add vsocket #26260
feat: add vsocket #26260
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
openshift-ci
bot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chifu1234 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
chifu1234
force-pushed
the
main
branch
2 times, most recently
from
7806b42 to
5e0499f
Compare
| if vsocket <= 2 { | ||
| vsocket = 3 | ||
| } |
There was a problem hiding this comment.
as this is always called you always pass cid=3 since the default config value is 0 which seems wrong.
There was a problem hiding this comment.
yes the default behavior should be that if nothing is set, that 3 is used (we could change that also to not set anything at all if 0). The only thing which is breaking if the user is setting a value below 3.
pkg/machine/vmconfigs/config.go
Outdated
| // VSocketCid ID for VSocket communication | ||
| VSocketCid int32 |
There was a problem hiding this comment.
If this is only implemented for qemu this must be in the qemu specific option.
But in general how is this intended to be used? This is not wired into the podman cli at all so the config value is never set anywhere.
There was a problem hiding this comment.
I fixed it. It is now used when calling podman machine start. I don't think we need to expose that setting with podman machine init or podman machine set what's your opinion ?
I need this feautre in order to use wayerpipe to forward a wayland session from guest to host. This way I can use UI application within a guest but display it on host.
There was a problem hiding this comment.
I don't know what wayerpipe is or what you are exactly trying to do. We do not support using our code directly as import somewhere else and don't offer a stable ABI (except for pkg/bindings)
In general I have no idea if forwarding a vsock has a use case for podman specifically so I would rather not support that. Podman machine is not meant to be a generic VM manager.
Signed-off-by: Kevin Klopfenstein <[email protected]>
Signed-off-by: Kevin Klopfenstein <[email protected]>
|
I'm having trouble seeing the application of this PR to podman machine as well. However, perhaps a better description of what you are trying to accomplish for the PR will generate more discussion. |
Does this PR introduce a user-facing change?
Yes. This will add a new field inside the machine config
.QEMUHypervisor.VSocketCidUsecase
Im using vsocket with waypipe in order to forward wayland session