Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Verify images in manifest list are not dangling and pruned #25562

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Mar 12, 2025

Vendor in latest containers/common

Currently if you create an un tagged image and add it to a manifest list, podman image prune will remove the image, and leave you with a broken manifest list. This PR removes the image from dangling in this situation and prevents the pruning.

We have seen this trigger issues with RamaLama which is creating manifest lists in this manner, and then users pruning the images.

Verifing: containers/common#2360

Does this PR introduce a user-facing change?


Vendor in latest containers/common

Currently if you create an un tagged image and add it to a manifest
list, podman image prune will remove the image, and leave you with
a broken manifest list. This PR removes the image from dangling in
this situation and prevents the pruning.

We have seen this trigger issues with RamaLama which is creating
manifest lists in this manner, and then users pruning the images.

Verifing: containers/common#2360

Signed-off-by: Daniel J Walsh <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2025
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2025
Copy link

Cockpit tests failed for commit 4c2d198. @martinpitt, @jelly, @mvollmer please check.

@martinpitt
Copy link
Contributor

Wrt. cockpit tests: The log shows a crash on podman rmi localhost/test-hello:latest. The full trace is huge, it starts with this:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x5586e472b513]

goroutine 1 gp=0xc000002380 m=7 mp=0xc00043e008 [running]:
panic({0x5586e5567600?, 0x5586e654fac0?})
	/usr/lib/golang/src/runtime/panic.go:806 +0x168 fp=0xc0004c30e0 sp=0xc0004c3030 pc=0x5586e3aa29a8

As your tests don't fail other than this "tree is dirty, please run 'make vendor'" in postinstall, please let me know if you need help with reproducing. But as this is still "WIP", I won't spend much time on this for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants