Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: bump c/common to PR c/common@2339 #25468

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

flouthoc
Copy link
Collaborator

@flouthoc flouthoc commented Mar 4, 2025

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]
[NO TESTS NEEDED]

Signed-off-by: flouthoc <[email protected]>
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: flouthoc
Once this PR has been reviewed and has the lgtm label, please assign ygalblum for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc flouthoc marked this pull request as draft March 4, 2025 22:24
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 4, 2025
@flouthoc flouthoc added the No New Tests Allow PR to proceed without adding regression tests label Mar 4, 2025
@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 4, 2025

Test containers/common#2339

@flouthoc
Copy link
Collaborator Author

flouthoc commented Mar 6, 2025

I think podman save --multi-image-archive (untagged images) and podman image scp transfer are expecting wrong output before this new c/common patch podman was attempting to save images to tar or copy to remote machine via id then while loading both test expect the images to not have names but now since we work directly with images so we can always get their original names back.

@mtrmac Any thoughts, while debugging I think both of these test are expecting wrong outputs.

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 7, 2025

I think the podman image scp transfer test is definitely correct and the code is buggy: It should not say “Loaded image” for a name which was not present at the source at all.

The podman save --multi-image-archive (untagged images) case seems to be similar: (Assuming the created archive does not contain tags) podman load should say which image names it loaded, not what it was deduplicated to.

See the review comments about reporting all of Image.Names() and not just the actually-loaded values.

@mtrmac
Copy link
Collaborator

mtrmac commented Mar 7, 2025

… the c/common review comments that is

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 10, 2025
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants