Skip to content

Conversation

@Luap99
Copy link
Member

@Luap99 Luap99 commented Nov 6, 2025

No description provided.

The type can no longer be used. I hav eno idea why it was used here, we
just return a normal Result so can use the default Rust Ok() here.

Signed-off-by: Paul Holzinger <[email protected]>
To 1.0.228 and 1.0.145 respectively.

Signed-off-by: Paul Holzinger <[email protected]>
@openshift-ci openshift-ci bot added the approved label Nov 6, 2025
@Luap99
Copy link
Member Author

Luap99 commented Nov 6, 2025

@baude @mheon @flouthoc PTAL

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomSweeneyRedHat
Copy link
Member

LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, Luap99, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mheon
Copy link
Member

mheon commented Nov 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Nov 7, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 4c794dc into containers:main Nov 7, 2025
28 checks passed
@Luap99 Luap99 deleted the serde-update branch November 7, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants