Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON formatting check to the add-ign function #189

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skyblaster
Copy link

Fixes #187

Copy link
Contributor

openshift-ci bot commented Dec 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: skyblaster
Once this PR has been reviewed and has the lgtm label, please assign edsantiago for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@baude
Copy link
Member

baude commented Dec 16, 2024

@skyblaster if you can fix the test failure, ill review and merge.

@skyblaster
Copy link
Author

@baude I'm unfamiliar with these particular tests, and not sure why it's failing, so will have to defer to @ashley-cui

If I download libhvee-0.6.0 or later releases, and run .\winmake.ps1 localtest on my local machine, I see the exact same errors.
If I simply run .\winmake.ps1 binaries, the executables are built without any errors.

@skyblaster
Copy link
Author

With a little debugging, I can say that the following URL needs to be updated as it results in a 404 which causes the win_test error:

fedoraBaseDirEndpoint = "https://kojipkgs.fedoraproject.org/compose/cloud/latest-Fedora-Cloud-39/compose"

Unfortunately it's not as simple as changing 39 to 40 or 41, as the new VHD images are compressed.

Example from 39: https://kojipkgs.fedoraproject.org/compose/metadata-archive/2024/Fedora-Cloud-39-20241126.0/images.json

                    {
                        "arch": "x86_64",
                        "bootable": false,
                        "checksums": {
                            "sha256": "b0ec83ff08499959ab9590cafc1d71645a48962ca10fbecf2aca2f6f3e0945ab"
                        },
                        "disc_count": 1,
                        "disc_number": 1,
                        "format": "vhd",
                        "implant_md5": null,
                        "mtime": 1732602402,
                        "path": "Cloud/x86_64/images/Fedora-Cloud-Base-Azure-39-20241126.0.x86_64.vhd",
                        "size": 1292184064,
                        "subvariant": "Cloud_Base",
                        "type": "vpc",
                        "volume_id": null
                    },

New compressed format: https://kojipkgs.fedoraproject.org/compose/cloud/latest-Fedora-Cloud-41/compose/metadata/images.json

                    {
                        "arch": "x86_64",
                        "bootable": false,
                        "checksums": {
                            "sha256": "c668dc15cddfae34649cb719c785bcbfdff858b10b2394fb6569bd676befa31a"
                        },
                        "disc_count": 1,
                        "disc_number": 1,
                        "format": "vhd.xz",
                        "implant_md5": null,
                        "mtime": 1734333904,
                        "path": "Cloud/x86_64/images/Fedora-Cloud-Base-Azure-41-20241216.0.x86_64.vhdfixed.xz",
                        "size": 527791932,
                        "subvariant": "Cloud_Base",
                        "type": "vhd-compressed",
                        "volume_id": null
                    },

@skyblaster
Copy link
Author

@baude I took a stab at fixing the e2e testing and it now passes.
The path to 41 seems to have disappeared, so I had to use 40.

I'm not sure why it appears to copy the decompressed image twice, so please have a look https://cirrus-ci.com/task/6376975813574656

Sorry for the lack of a sign-off. Please let me know if I should rebase, or resubmit the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kvpctl check for properly formatted JSON
2 participants