-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add JSON formatting check to the add-ign function #189
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: skyblaster The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@skyblaster if you can fix the test failure, ill review and merge. |
@baude I'm unfamiliar with these particular tests, and not sure why it's failing, so will have to defer to @ashley-cui If I download libhvee-0.6.0 or later releases, and run |
With a little debugging, I can say that the following URL needs to be updated as it results in a 404 which causes the win_test error: libhvee/test/e2e/fedora_test.go Line 18 in 24e21b4
Unfortunately it's not as simple as changing 39 to 40 or 41, as the new VHD images are compressed. Example from 39: https://kojipkgs.fedoraproject.org/compose/metadata-archive/2024/Fedora-Cloud-39-20241126.0/images.json
New compressed format: https://kojipkgs.fedoraproject.org/compose/cloud/latest-Fedora-Cloud-41/compose/metadata/images.json
|
@baude I took a stab at fixing the e2e testing and it now passes. I'm not sure why it appears to copy the decompressed image twice, so please have a look https://cirrus-ci.com/task/6376975813574656 Sorry for the lack of a sign-off. Please let me know if I should rebase, or resubmit the PR. |
Fixes #187