update godoc button in README for image/v5 #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
requested changes
Nov 4, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
Thanks, you must add a DCO sign off to the commit https://github.com/containers/container-libs/blob/main/CONTRIBUTING.md#sign-your-prs
image/README.md
Outdated
| @@ -1,4 +1,4 @@ | |||
| [](https://pkg.go.dev/github.com/containers/image/v5) [](https://cirrus-ci.com/github/containers/image) | |||
| [](https://pkg.go.dev/go.podman.io/image/v5) [](https://cirrus-ci.com/github/containers/image) | |||
Member
There was a problem hiding this comment.
typo go.padman.io
I think you can just drop the cirrus CI link, it doesn't add any value. It would need to get changed with s/image/container-libs/ to pick the current repo location CI wise but it doesn't make sense to show this link in the image subdirectory IMO.
Fixes the godoc button link to the new URL and removes the unused cirrusci badge. Fixes containers#435 Signed-off-by: Jeff Hodges <[email protected]>
Author
|
@Luap99 Feedback handled! Thanks for the review! |
Luap99
reviewed
Nov 5, 2025
| @@ -1,4 +1,4 @@ | |||
| [](https://pkg.go.dev/github.com/containers/image/v5) [](https://cirrus-ci.com/github/containers/image) | |||
| [](https://pkg.go.dev/go.podman.io/image/v5) | |||
Member
There was a problem hiding this comment.
another typo in the badge svg link, it doesn't seem to matter for the picture but still it should be right :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435