Make some test files different from each other #6405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
do-not-merge/work-in-progress
kind/failing-test
|
Well, I for one am surprised that that passed. |
openshift-ci
bot
changed the title
|
Oh, it hasn't yet. |
In case there's some opportunistic hard linking going on, which might be causing problems when the tests are packaged and run in an environment which is wildly different from CI. Signed-off-by: Nalin Dahyabhai <[email protected]>
nalind
force-pushed
the
are-you-hardlinking-identical-files
branch
from
26df4b4 to
a654d35
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
In case there's some opportunistic hard linking going on, which might be causing problems when the tests are packaged and run in an environment which is wildly different from CI.
How to verify it
That test should pass.
Which issue(s) this PR fixes:
Special notes for your reviewer:
This is just a guess.
Does this PR introduce a user-facing change?