Include the Sequoia crypto backend, and run integration tests with it #6390
Conversation
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mtrmac
force-pushed
the
sequoia
branch
4 times, most recently
from
7800339 to
b844ac6
Compare
mtrmac
changed the title
mtrmac
changed the title
|
@containers/buildah-maintainers PTAL, I’m not familiar with the test setup in this repo. Ultimately, this seems to be just a compile-test of the crypto backend: I have manually verified that the binary does build with the Sequoia build tag, and does include the Sequoia implementation — but ~all tests here run with Unlike Podman and Skopeo, this does not add new UI: Buildah doesn’t have a |
lsm5
left a comment
lsm5
left a comment
There was a problem hiding this comment.
LGTM.
We should also update rpm/buildah.spec to include the new buildtag, but that can be in another PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, lsm5, mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mtrmac looks like you have some conflicts that need tending to. |
Follow up on containers#6390 Signed-off-by: Lokesh Mandvekar <[email protected]>
This mirrors the same Make veriable in Skopeo and (proposed) Podman. Signed-off-by: Miloslav Trmač <[email protected]>
This extra test run is temporary; it should be removed after rust-podman-sequoia makes it to a stable Fedora release. Signed-off-by: Miloslav Trmač <[email protected]>
|
Rebased (with no code changes — just dropped the first dependency update commit), PTAL again. |
|
Just to be sure: this test is meant to be must-pass-to-merge and not simply informative? |
|
Yes, I was thinking must-pass-to-merge — with the distribution dependency moving as new Fedoras are released. I.e. after we move to Fedora.next, have the “Fedora” run done with Sequoia, and drop the “Rawhide” run again; and one release after that, have the “previous Fedora” run done with Sequoia as well. The extra test run would only persist as until Fedora 43 is released and used in CI. |
|
Okay, then. |
Follow up on containers#6390 Signed-off-by: Lokesh Mandvekar <[email protected]>
Follow up on containers#6390 Signed-off-by: Lokesh Mandvekar <[email protected]>
5 participants
What type of PR is this?
What this PR does / why we need it:
To support Buildah builds using the Sequoia crypto backend, it would be useful to have at least some tests.
How to verify it
Manually inspect that the tests use a Sequoia build.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?