bridge-cni: add uplinkInterface to configure VLANs#1195
Open
boebu wants to merge 1 commit intocontainernetworking:mainfrom
Open
bridge-cni: add uplinkInterface to configure VLANs#1195boebu wants to merge 1 commit intocontainernetworking:mainfrom
boebu wants to merge 1 commit intocontainernetworking:mainfrom
Conversation
Allow bridge-cni to configure the bridge's uplink interface in L2-only vlan configuration with additional VLANs as defined by the CNI. Signed-off-by: boebu <boban@meltcloud.io>
boebu
force-pushed
the
enable-vlan-uplink-interface
branch
from
898076c to
2cbad13
Compare
Member
|
Could you please provide more details about the use case? Is using an external tool to configure the uplink interface not an option? Also, how would this change be reverted? Even with cleanup code in the CNI DEL command, we could end up in a situation similar to the L3 VLAN gateway interface issue (#1175). This logic seems intended for L2 scenarios, but it's missing a check to skip this behavior for L3. It would also be good to ensure that ensureUplinkVlan is only called when the vlan or vlans parameters are actually set. I think this should be handled externally and not by the plugin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the documentation for bridge-cni L2 vlan-only setup suggests to manually add vlans to the corresponding uplink interface, if outbound connectivity is required.(https://github.com/containernetworking/cni.dev/blob/512744c6eedde79c53308e785c70d90bde7baa61/content/plugins/current/main/bridge.md?plain=1#L112)
This PR enhances the bridge-cni configuration to allow autoconfiguration of the uplink interface with specified vlans. This is especially useful for setups where the bridge and uplink in configured by the underlying operating system.