-
Notifications
You must be signed in to change notification settings - Fork 85
api,adaptation,generate: allow setting kernel scheduling policy attributes. #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e81249c to
a3c9e02
Compare
43cf40f to
237b6dc
Compare
75064ad to
bc46504
Compare
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bc46504 to
26674c5
Compare
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after rebase
26674c5 to
653fae6
Compare
@mikebrow Rebased and pushed. |
|
once more to rebase/merge in #135 changes |
653fae6 to
a231512
Compare
Rebased and updated. |
a231512 to
2749cb5
Compare
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2749cb5 to
d591be8
Compare
d591be8 to
4227dd4
Compare
Allow setting/resetting container linux scheduler attributes. Signed-off-by: Krisztian Litkey <[email protected]>
Signed-off-by: Krisztian Litkey <[email protected]>
4227dd4 to
6a371ac
Compare
|
@mikebrow Rebased on latest HEAD, to make it mergable again. |
mikebrow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Allow plugins to set container kernel scheduling policy attributes.
This is the corresponding Process.Scheduler OCI Spec field this PR allows adjusting: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L92
This is how Scheduler is defined in the OCI Spec: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L38
And here are the related scheduler policy and flag definitions: https://github.com/opencontainers/runtime-spec/blob/524fc0e1b8ab0180e2fc9abd31837a0f4ed1fd6b/specs-go/config.go#L880
The related NRI types are all straightforward protobuf defined message representations of the corresponding OCI Spec types.