-
Notifications
You must be signed in to change notification settings - Fork 634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HostConfig to nerdctl inspect
response
#3812
Open
coderbirju
wants to merge
15
commits into
containerd:main
Choose a base branch
from
coderbirju:add-hostconfig-inspect-response
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add HostConfig to nerdctl inspect
response
#3812
coderbirju
wants to merge
15
commits into
containerd:main
from
coderbirju:add-hostconfig-inspect-response
+680
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
reviewed
Jan 14, 2025
AkihiroSuda
reviewed
Jan 14, 2025
AkihiroSuda
reviewed
Jan 14, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
January 15, 2025 05:15
f57dca7
to
cfdf044
Compare
AkihiroSuda
reviewed
Jan 15, 2025
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
5 times, most recently
from
January 22, 2025 22:52
0b7af18
to
64ad424
Compare
coderbirju
changed the title
[WIP]: Add HostConfig to
Add HostConfig to Jan 22, 2025
nerdctl inspect
responsenerdctl inspect
response
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
19 times, most recently
from
January 30, 2025 17:41
7052b62
to
c5794d5
Compare
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
2 times, most recently
from
January 30, 2025 18:54
a002197
to
f36f024
Compare
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
Signed-off-by: Arjun Raja Yogidas <[email protected]>
coderbirju
force-pushed
the
add-hostconfig-inspect-response
branch
from
January 30, 2025 19:27
f36f024
to
41ace87
Compare
@AkihiroSuda PTAL, I've tried to limit the use of labels and use the native inspect as much as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl inspect
currently doesn't report HostConfig details in its response.Attempting to add this PR as a starting point, aim is to get the
dockercompat
response closer to the docker inspect response schema