Refactor: Encapsulate net opts loading in internalLabels #3793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pedro Aibar <[email protected]>
yankay
reviewed
Jan 2, 2025
pkg/cmd/container/create.go
Outdated
| @@ -732,6 +726,16 @@ func withInternalLabels(internalLabels internalLabels) (containerd.NewContainerO | |||
| return containerd.WithAdditionalContainerLabels(m), nil | |||
| } | |||
|
|
|||
| // LoadNetOpts loads network options into InternalLabels. | |||
| func (il *internalLabels) LoadNetOpts(opts types.NetworkOptions) { | |||
There was a problem hiding this comment.
LoadNetOpts is a public function. Could you please clarify why it is necessary for this function to be public rather than private?"
There was a problem hiding this comment.
Making LoadNetOpts public was unintentional. I've already updated the function to be private to align with its intended use case.
Signed-off-by: Pedro Aibar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The
create.gofile contained a TODO to formalize the way networkoptions are loaded into
internalLabels. The previous implementationmanually assigned each field, which made it harder to maintain and extend.
Solution
LoadNetOptsin theinternalLabelsstruct.maintainability and extensibility.
Impact
This change is backward-compatible and does not affect existing functionality.
Signed-off-by: Pedro Aibar [email protected]