Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main #3437

Open
apostasie opened this issue Sep 18, 2024 · 6 comments
Open

[URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main #3437

apostasie opened this issue Sep 18, 2024 · 6 comments
Labels
area/ci e.g., CI failure bug Something isn't working platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2)

Comments

@apostasie
Copy link
Contributor

Description

See #3436 for a no-op PR that fails the test.

This has been failing a lot on all my recent PRs, but seems racy.

It is possibly a recent regression.

Steps to reproduce the issue

na

Describe the results you received and expected

na

What version of nerdctl are you using?

main

Are you using a variant of nerdctl? (e.g., Rancher Desktop)

None

Host information

No response
@apostasie apostasie added the kind/unconfirmed-bug-claim Unconfirmed bug claim label Sep 18, 2024
@apostasie apostasie mentioned this issue Sep 18, 2024
Merged
@apostasie apostasie changed the title [URGENT] Regression? TestRunWithTtyAndDetached is broken [URGENT] Regression? TestRunWithTtyAndDetached is broken on main Sep 18, 2024
@apostasie apostasie changed the title [URGENT] Regression? TestRunWithTtyAndDetached is broken on main [URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main Sep 18, 2024
@apostasie
Copy link
Contributor Author

Note: github is experiencing network issues rn, so.......

@apostasie apostasie changed the title [URGENT] Regression? TestRunWithTtyAndDetached on windows is broken on main [URGENT] Regression? TestRunWithTtyAndDetached on windows appears broken on main Sep 18, 2024
@apostasie
Copy link
Contributor Author

https://github.com/containerd/nerdctl/actions/runs/10950055624/job/30404542869?pr=3435#step:8:473

@AkihiroSuda AkihiroSuda added bug Something isn't working area/ci e.g., CI failure platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2) and removed kind/unconfirmed-bug-claim Unconfirmed bug claim labels Sep 19, 2024
@apostasie
Copy link
Contributor Author

https://github.com/containerd/nerdctl/actions/runs/10965099031/job/30450151113?pr=3418#step:8:565

@apostasie
Copy link
Contributor Author

https://github.com/containerd/nerdctl/actions/runs/10968930365/job/30460923241?pr=3446#step:8:473

@apostasie
Copy link
Contributor Author

https://github.com/containerd/nerdctl/actions/runs/10974186024/job/30472417850?pr=3435#step:9:476

This was referenced Sep 25, 2024
Open
Merged
Open
Open
Merged
@apostasie
Copy link
Contributor Author

@AkihiroSuda this is a major pita.
I know it is just a test, but it is failing incredibly often which begs the question of whether the code is really working.

Tagging for milestone v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci e.g., CI failure bug Something isn't working platform/Windows/Non-WSL2 Microsoft Windows (non-WSL2)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AkihiroSuda @apostasie