Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] filter images panic #3469

Merged
merged 1 commit into from
Sep 28, 2024
Merged

[fix] filter images panic #3469

merged 1 commit into from
Sep 28, 2024

Conversation

xyz-li
Copy link
Contributor

@xyz-li xyz-li commented Sep 26, 2024

nerdctl images --filter before=not-exist-image will panic.

Fix: #3467

austinvazquez
austinvazquez reviewed Sep 26, 2024
View reviewed changes
Copy link
Contributor

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Would you mind adding a test case to TestImagesFilter to validate providing before and since filter for an image that does not exist?

@apostasie
Copy link
Contributor

CI failures notes:

@apostasie
Copy link
Contributor

Tagging @djdongjin @AkihiroSuda for maintainers review.

@AkihiroSuda AkihiroSuda added this to the v2.0.0 milestone Sep 28, 2024
AkihiroSuda
AkihiroSuda approved these changes Sep 28, 2024
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@AkihiroSuda AkihiroSuda merged commit cd4a62a into containerd:main Sep 28, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@apostasie apostasie apostasie approved these changes

@austinvazquez austinvazquez Awaiting requested review from austinvazquez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

nerdctl images filter panic
4 participants
@xyz-li @apostasie @AkihiroSuda @austinvazquez