fix(sandbox): add context to vm errors - #261
Merged
dmcgowan merged 1 commit intoJul 29, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves debuggability of the VM-backed sandbox implementation by adding contextual messages to ErrFailedPrecondition returns, making it clearer which sandbox lifecycle assumption was violated.
Changes:
- Wrap
errdefs.ErrFailedPreconditionwith a clearer message whenStart()is called on an already-started sandbox. - Wrap
errdefs.ErrFailedPreconditionwith a clearer message whenStop(),Client(), orStartStream()are called before the sandbox is started.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
austinvazquez
force-pushed
the
fix/add-context-to-sandbox-errors
branch
from
July 29, 2026 20:16
f448f5f to
ced59d5
Compare
dmcgowan
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds context to sandbox vm errors so it is more clear to the caller the assumption that was broken resulting in the error.