feat: add pretty fixtures for quoting and formatting behaviors#246
Merged
pyramation merged 1 commit intomainfrom Dec 25, 2025
Merged
feat: add pretty fixtures for quoting and formatting behaviors#246pyramation merged 1 commit intomainfrom
pyramation merged 1 commit intomainfrom
Conversation
Add test fixtures documenting deparser behavior for:
- Quoted function names (float, interval, boolean) as reserved keywords
- pg_catalog.substring with quoted identifier
- EXPLAIN with optional COSTS OFF keyword
- Boolean literal formatting ('t'::boolean vs TRUE)
- Parenthesization/argument formatting with IN parameter mode
Both input forms and canonical forms are included where applicable
to test both the transformation and idempotence.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: add pretty fixtures for quoting and formatting behaviors
Summary
Adds test fixtures to document deparser behavior for several SQL formatting scenarios observed in downstream repos:
Quoting fixtures (
quoting.sql):float,interval,boolean) that require quotingpg_catalog."substring"with quoted identifierFormatting fixtures (
formatting.sql):EXPLAINwith/withoutCOSTS OFFoptional keyword't'::booleancast vsTRUEliteral)IN,OUT,INOUT) with parenthesizationReview & Testing Checklist for Human
faker.float(unquoted input) deparsing tofaker."float"(quoted output) - this is the key transformation being documented't'::booleanbecomesCAST('t' AS boolean)rather thanTRUE- confirm this matches expected deparser behavior (differs from original diff which showedTRUE)SUBSTRING(value FROM 'pattern')SQL syntax was excluded because it cannot round-trip (different AST representation) - only the canonicalpg_catalog."substring"(value, 'pattern')form is testedTest plan:
Notes