Add CREATE FOREIGN TABLE fixture with schema-qualified column type#243
Closed
pyramation wants to merge 1 commit intomainfrom
Closed
Add CREATE FOREIGN TABLE fixture with schema-qualified column type#243pyramation wants to merge 1 commit intomainfrom
pyramation wants to merge 1 commit intomainfrom
Conversation
Co-Authored-By: Dan Lynch <pyramation@gmail.com>
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new SQL fixture for
CREATE FOREIGN TABLEthat tests a combination not covered by existing fixtures:pg_catalog.varchar(50))schema_name,table_name)The existing
upstream/foreign_data.sqlhas extensive foreign table coverage but uses unqualified types likeinteger,text,date. This fixture adds coverage for qualified type names with type modifiers in foreign table column definitions.Review & Testing Checklist for Human
pnpm testin packages/deparser)pg_catalog.varchar(50)in a foreign table) isn't already covered elsewhere in the fixturesNotes