Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the master-slave phrasing #4

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bopopescu
Copy link

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

@codecov
Copy link

codecov bot commented Jul 19, 2020

Codecov Report

Merging #4 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #4   +/-   ##
=======================================
  Coverage   91.49%   91.49%           
=======================================
  Files          13       13           
  Lines         494      494           
=======================================
  Hits          452      452           
  Misses         42       42           
Impacted Files Coverage Δ
dnsmanager/migrations/0001_initial.py 100.00% <ø> (ø)
dnsmanager/models.py 95.80% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a023037...ec25cdb. Read the comment docs.

@mbombar
Copy link
Member

mbombar commented Jul 20, 2020

Hi ! The master/slave terminology is not really something we care of, and we would be happy to change it if it makes somebody uncomfortable to use our app. However, this is the official terminology for the main dns servers like bind9 or knot.
For instance here, in the source code of bind9 :
https://github.com/isc-projects/bind9/blob/3a5a508a0bc4fc7558b14679e77dc58bbc0b0ea4/lib/dns/include/dns/master.h#L38

I suggest making a PR there first, then when it will be changed upstream, we may update django-dnsmanager.

@mbombar mbombar closed this Jul 20, 2020
@mbombar mbombar reopened this Jul 20, 2020
@mbombar
Copy link
Member

mbombar commented Jul 20, 2020

In fact, we can use primary/secondary instead of master/slave. It can also be used equivalently in the configuration of bind9.
You may update the PR.

However, what do you think about webmaster : You also changed it in your PR, but this is the right terminology. I think that nobody uses webmain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants