Update the analytics CDK stack #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanejearley
reviewed
Dec 5, 2023
| tags: [{ key: "version", value: config.dataVersion.toString() }], | ||
| }) | ||
|
|
||
| this.workGroupName = workGroup.name |
There was a problem hiding this comment.
Where are you using the workGroupName?
Is it at all necessary to tie the work group to the glue database? Or this is just on the Athena side?
There was a problem hiding this comment.
You are right it is not needed I can match the workGroup with the output bucket.
If we don't tie them here with a workgroup then we have to update the location in the console manually.
shanejearley
reviewed
Dec 5, 2023
| }, | ||
| "amount": { | ||
| "type": "string", | ||
| "type": "number", |
There was a problem hiding this comment.
Are you keeping all decimals, rounding, or keeping the original big int?
There was a problem hiding this comment.
Currently we are losing precision. I will store it as a string and let Athena handle casting CAST(amount AS DECIMAL(12, 4)). That would keep it precise and flexible.
shanejearley
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkGroupto connect the S3 output bucket to the Glue database. We had the bucket before but it wasn't being used correctly.