Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rebalance bug and add sanity check #454

Merged
merged 22 commits into from
Nov 4, 2023
Merged

Fix rebalance bug and add sanity check #454

merged 22 commits into from
Nov 4, 2023

Conversation

shanejearley
Copy link
Contributor

@shanejearley shanejearley commented Nov 2, 2023 •
edited
Loading

Had to pause the testnet contract briefly and address an issue, but the contract is now unpaused. The remainder of the PR will be cleanup for the next iteration.

  • Archived a script used to correct testnet issues from a rebalance bug
  • Added an onchain sanity check to the rebalance method to prevent the bug
  • Fixed incorrect passing and handling of start and end indicies in functions calls to views
  • Changed ethereum dev script to use already deployed contracts in fork
  • Todo: tighten up Functions oracle source code to mitigate other unchecked conditions

shanejearley and others added 22 commits June 14, 2023 11:40
@shanejearley
Merge pull request #330 from consensusnetworks/develop
01bddae 
Promote develop to master
@shanejearley
Merge pull request #359 from consensusnetworks/develop
266f0f7 
Promote develop to master
@shanejearley
Merge pull request #373 from consensusnetworks/develop
f91a3e9 
Promote develop to master
@shanejearley
Merge pull request #397 from consensusnetworks/develop
3b4412a 
Promote develop to master
@shanejearley
Merge pull request #405 from consensusnetworks/develop
2a3dd4e 
Promote develop to master
@shanejearley
Merge pull request #406 from consensusnetworks/develop
7d5f658 
Promote develop to master
@shanejearley
Merge pull request #418 from consensusnetworks/develop
a51906f 
Promote develop to master
@shanejearley
Merge pull request #435 from consensusnetworks/develop
3c0c0de 
Promote develop to master
@shanejearley
Merge branch 'develop'
a1f0b9d
@shanejearley
Release v1.0.0-beta.1
f24bb00
@shanejearley
Merge pull request #447 from consensusnetworks/develop
5c81be0 
Promote develop to master
@shanejearley
Release v1.0.0-beta.2
783a59e
@shanejearley
Merge branch 'develop'
cae0e32
@shanejearley
Release v1.0.0-beta.3
338c1a7
@shanejearley
Push current report fix
87907b8
@shanejearley
Uncomment fulfillment
41a5aa9
@shanejearley
Update statuses
8faf909
@shanejearley
Fix rebalance bug and add sanity check
73be1f6
@shanejearley
Bump go version
7be0cd2
@shanejearley
Use deployed contract fork in dev script
ae04716
@shanejearley
Emit request ID and args on request from upkeep
bd0d6f5
@shanejearley
Fix start and end index in functions source
16ed350
@shanejearley shanejearley merged commit f2ed3ce into develop Nov 4, 2023
1 check passed
@shanejearley shanejearley deleted the bug/functions branch November 4, 2023 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shanejearley