Update/composables #421
Merged
Update/composables #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@shanejearley - @DemogorGod and I worked through a bit of a rewrite of the composables in order to simplify the number of inter-dependencies between composables.
useUseris now the primary composable that cascades to the primary components of the app by passingreadonlyvalues to the respective components and exporting a limited set of methods. This allows most/all of the logic that modifies critical values to be contained within the same composable, which, again, will simplify logic but also future development. 👍I originally checked this branch off of my WalletConnect branch (
feature/wallet-connect-v2), but I've incorporated the current status ofdevelopinto it and it should be good to merge. WalletConnect is still not yet "done", although I still am working on diagnosing what is actually going wrong (might not be a function of the application code logic, although either way I plan to clean that composable up a bit before submitting another PR on it).Looking forward to any questions / feedback.