Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

veLON contract with early withdrawal penalty #58

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

veLON contract with early withdrawal penalty #58

wants to merge 5 commits into from

Conversation

zeqing-guo
Copy link

  1. Forked from veMULTI
  2. Supported early withdrawal penalty
  3. Add some foundry test cases:
    1. initializing the project
    2. testing staking
    3. testing early withdrawal
  4. Improve the coding style

@NIC619
Copy link
Contributor

NIC619 commented Jul 19, 2022

It would be great if commit 33261c3 can be split into two: first copy ve.sol and second apply changes on top. Then we can review second commit and see the new changes applied to ve.sol.

@charlesjhongc
Copy link
Contributor

After discussion, I'll refactor the implementation in another PR. Keep this one opened for now so new feature and test can be added without being blocked.

@charlesjhongc
Copy link
Contributor

Let's keep this PR opened as a reference until refactored implementation get merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charlesjhongc charlesjhongc Awaiting requested review from charlesjhongc

@eric6311 eric6311 Awaiting requested review from eric6311

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zeqing-guo @NIC619 @charlesjhongc