Feature/webusb eth #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuNeal
requested changes
Jul 5, 2021
src/hw-app-eth/Eth.ts
Outdated
| continue | ||
| } | ||
| } | ||
| const v = (rec_id + 27).toString(16); |
There was a problem hiding this comment.
signature 转成 rsv 如果抽象出一个函数，上面和这里就可以重用了。
| message_to_sign = Buffer.from(message, "ascii"); | ||
| } | ||
| let data | ||
| if (isPersonalSign) { |
There was a problem hiding this comment.
可以看看别的 API 是如何实现的， tcx 内部确实这么实现的，但是给到上层 API, personalSign 和 signMessage 应该也是区分开的。
src/hw-app-eth/Eth.ts
Outdated
| } | ||
| } | ||
|
|
||
| function bindSignature(data: Buffer) :Buffer{ |
src/hw-transport-webusb/webusb.ts
Outdated
| // const deviceModel = devicesList.find(d => d.id === productId); | ||
| // return deviceModel; | ||
| // }; | ||
| export async function requestimkeyDevice(): Promise<any> { |
There was a problem hiding this comment.
在驼峰写法中可以考虑将 imKey 写作 ImKey 例如这里写作 requestImKeyDevice
src/index.ts
Outdated
| } else { | ||
| return num.toString(); | ||
| } | ||
| } | ||
|
|
||
| export async function test33(){ |
There was a problem hiding this comment.
index.ts 已经是正式的库文件代码了。这些没用的函数都删掉吧。
added 2 commits
July 15, 2021 22:47
XuNeal
approved these changes
Jul 16, 2021
…/webusb-eth # Conflicts: # src/demo.ts # src/hw-transport-mocker/RecordStore.ts
…to feature/webusb-eth
Refactor/webusb eth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.