Feature/webusb eth #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuNeal
commented
May 6, 2021
src/common/apdu.ts
Outdated
| ]) | ||
| return response; | ||
| } | ||
| function get_pubkey( path: string, ins: number, verify_flag: boolean) : Buffer { |
There was a problem hiding this comment.
最好在JS中所有方法都统一成camelCase
src/common/apdu.ts
Outdated
| return genApdu(0x80,ins,p1,0x00,Buffer.from(path,"ascii")); | ||
| } | ||
| function register_address( ins: number, data: Buffer = Buffer.alloc(0)) : Buffer { | ||
| return genApdu(0x80,ins,0x00,0x00,data); |
There was a problem hiding this comment.
0x80和 0x00 最好有个常量定义，不然代码读起来比较累
src/errors/index.ts
Outdated
| * Error thrown when a devices returned a non success status. | ||
| * the error.statusCode is one of the `StatusCodes` exported by this library. | ||
| */ | ||
| export function TransportStatusError(statusCode: number): void { |
There was a problem hiding this comment.
这边可以尝试用ts 的写法 class TransportStatusError extends Error {}
src/hw-app-eth/Eth.ts
Outdated
| fee: string, | ||
| } | ||
| const eth_apdu = ethApdu(); | ||
| const remapTransactionRelatedErrors = (e) => { |
There was a problem hiding this comment.
这段代码应该是 Ledger 特有的代码，我们应该用不到
src/hw-app-eth/Eth.ts
Outdated
| let pri_key = Buffer.from("18e14a7b6a307f426a94f8114701e7c8e774e7f9a47e2c2035db29a206321725","hex"); | ||
| let ha256_hash = utils.sha256(utils.sha256(data_to_sign)).substring(2) | ||
| let bind_signature = secp256k1.ecdsaSign(Buffer.from(ha256_hash,"hex"),pri_key).signature | ||
| let bind_signature_r =(bind_signature[0]>0x80) ? Buffer.concat( |
There was a problem hiding this comment.
接下来的一些代码看起来和上面很像，不能合并到一起吗？
src/hw-app-eth/utils.ts
Outdated
| } | ||
|
|
||
| // TODO use bip32-path library | ||
| export function splitPath(path: string): number[] { |
There was a problem hiding this comment.
上面还有一个splitPath 这两个方法用哪个？
src/hw-transport-webusb/webusb.ts
Outdated
| if (legacy) return legacy; | ||
|
|
||
| const mm = usbProductId >> 8; | ||
| console.log("mmmmmmmm:"+mm) |
…/webusb-eth # Conflicts: # src/demo.ts # src/hw-transport-mocker/RecordStore.ts
…to feature/webusb-eth
Refactor/webusb eth
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.