Terraform 0.12 update #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luthes
force-pushed
the
feature.tf12update
branch
from
1d75e3a to
8760f70
Compare
|
Thanks so much for this PR, @luthes! Apologies for taking this long to see it. At first glance, this looks great. Since I don't have any automated tests, I will test this out manually and then get it merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds variable types to the variables.tf, as well as for loops instead of count for resources. This module still worked under 0.12, but I think it's better to update it using the new constructs.
A lot of formatting fixes as well, simply running
terraform fmtchanged quite a bit, so there might seem like quite a few more changes than there really are.