Skip to content

misc: fixes / todo #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
connorabbas merged 1 commit into from
Oct 30, 2025
Merged

misc: fixes / todo #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/meilisearch/ImportDocumentsDrawer.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ watch(uploadContentType, (newVal) => {
:multiple="false"
:previewWidth="0"
:fileLimit="1"
:maxFileSize="20000000"
:showUploadButton="false"
:showCancelButton="false"
:pt="{
Expand Down
3 changes: 2 additions & 1 deletion src/composables/meilisearch/useDocuments.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ export function useDocuments() {
}
}

// example data: https://github.com/meilisearch/datasets/tree/main/datasets
async function addOrUpdateDocumentsFromString(
action: 'addition' | 'update',
indexUid: string,
Expand Down Expand Up @@ -255,4 +256,4 @@ export function useDocuments() {
confirmDeleteAllDocuments,
confirmDeleteDocument,
}
}
}
12 changes: 6 additions & 6 deletions src/utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,11 @@ export function looksLikeAnImageUrl(value: any) {
const url = new URL(value)
const path = url.pathname.toLowerCase()
return (
path.endsWith('.jpg') ||
path.endsWith('.jpeg') ||
path.endsWith('.gif') ||
path.endsWith('.png') ||
path.endsWith('.webp')
path.includes('.jpg') ||
path.includes('.jpeg') ||
path.includes('.gif') ||
path.includes('.png') ||
path.includes('.webp')
)
};

Expand Down Expand Up @@ -109,4 +109,4 @@ export function readFileAsText(file: File): Promise<string> {

reader.readAsText(file)
})
}
}
1 change: 1 addition & 0 deletions src/views/Tasks.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ function showTask(task: Task) {
showTaskDrawerOpen.value = true
}

// TODO: poll for new tasks
// TODO: https://vueuse.org/core/useUrlSearchParams/
// url params for route redirect from index page tasks link, or use qs package?
watch(tasksParams, (newValue) => {
Expand Down