This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Confirmation patch #657
Open
Confirmation patch #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhlsthrm
approved these changes
Jun 11, 2021
|
Can't repro the issues/failures in the CI for this. The only additional functionality I added was the additional argument for the |
Just wanted to let you know, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Problem
Nonce has expired, but sometimes takes longer than 45 sec to confirm. Results in a UI/UX issue - the tx eventually goes through, but our store/application state does not reflect it.
The Solution
Sledgehammer fix for issue where nonce expired, and we re-check for confirmation. Wait for an extended period when nonce has expired.
Also added some good juicy logs in there (and removed a redundant "Tx submitted." log)