Skip to content

Adjust CI workflow definitions #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025
Merged

Adjust CI workflow definitions #348

merged 1 commit into from
May 23, 2025

Conversation

eseay
Copy link
Contributor

@eseay eseay commented May 23, 2025

Primary change: Updates our CI jobs to use Xcode 16.3

Secondary changes:

  • Adjusts the way that we specify our Xcode version to reduce duplication (and instances where changes need to be made in the future)
  • Removes redundant installation of xcbeautify now that is pre-installed on the runners (it was not always pre-installed)
  • Renamed all workflow file extensions to yml for consistency

@eseay eseay force-pushed the eddie/concurrency-testing branch 2 times, most recently from 5ec4475 to 45e347d Compare May 23, 2025 14:56
@eseay eseay changed the title Update CI Xcode version CI Refinements May 23, 2025
@eseay eseay changed the title CI Refinements Adjust CI workflow definitions May 23, 2025
@eseay eseay requested review from Copilot and rebello95 May 23, 2025 15:03
@eseay eseay marked this pull request as ready for review May 23, 2025 15:03
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the CI workflows to use Xcode 16.3 and simplifies the configuration by setting the Xcode version via an environment variable instead of invoking xcode-select in each job. In addition, it removes the redundant installation of xcbeautify where it is now pre-installed on the runners and updates the simulator OS versions for some builds.

  • Sets the DEVELOPER_DIR environment variable for Xcode 16.3.
  • Removes redundant xcode-select commands.
  • Updates simulator OS versions in build steps.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
.github/workflows/release.yml Introduces DEVELOPER_DIR env var and removes xcode-select step.
.github/workflows/ci.yaml Introduces DEVELOPER_DIR env var, removes redundant xcode-select and xcbeautify installation steps, and updates simulator OS versions.

@eseay eseay force-pushed the eddie/concurrency-testing branch from 45e347d to cc8410c Compare May 23, 2025 15:05
Copy link
Collaborator

@rebello95 rebello95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Also removes installation of xcbeautify, which is now pre-installed on runners
Signed-off-by: Eddie Seay <[email protected]>
@eseay eseay force-pushed the eddie/concurrency-testing branch from cc8410c to 956a2b6 Compare May 23, 2025 16:34
@eseay eseay changed the base branch from rebello-fix-concurrency to main May 23, 2025 16:35
@eseay eseay merged commit bd83d0f into main May 23, 2025
14 checks passed
@eseay eseay deleted the eddie/concurrency-testing branch May 23, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants