Refactor memhttptest to work with Go 1.25 synctest #881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Sep 22, 2025
|
@codefromthecrypt, can you take a look at the comments I left the other week? I think it would be a small revision to get CI passing and get this merged. |
|
Haha wow blast from the past. Nice seeing you again (x-square) will do today |
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
synctest
branch
from
3c4b7d6 to
6539bb7
Compare
|
sorry was in a deep code hole. will keep better watch on my PRs next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that things were basically already aligned for the Go 1.25 synctest package, just that a helper to shutdown the client could avoid bursted bubble panics. Feel free to tell me if this isn't desired, as I know it is random.
https://pkg.go.dev/testing/synctest@master