use hasPresence instead of proto3 checks #3926
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
See #3925
Checklist
Please answer the questions with Y, N or N/A if not applicable.
References
#3569
Test & Review
Haven't tested it. Only found the bug by using the FileStreamSinkConnector with a Protobuf message similar to the one described in the issue and seeing that field-presence tracking is not respected by Kafka Connect.
Open questions / Follow-ups
Should this be gate-kept by a feature flag?
Review stakeholders
@rayokota