Skip to content

Conversation

ubiquitousbyte
Copy link

@ubiquitousbyte ubiquitousbyte commented Oct 5, 2025

What

See #3925

Checklist

Please answer the questions with Y, N or N/A if not applicable.

  • [Y] Contains customer facing changes? Including API/behavior changes
  • [N] Is this change gated behind config(s)?
  • [N] Did you add sufficient unit test and/or integration test coverage for this PR?
    • If not, please explain why it is not required
  • [N/A] Does this change require modifying existing system tests or adding new system tests?
    • If so, include tracking information for the system test changes
  • [N] Must this be released together with other change(s), either in this repo or another one?
    • If so, please include the link(s) to the changes that must be released together

References

#3569

Test & Review

Haven't tested it. Only found the bug by using the FileStreamSinkConnector with a Protobuf message similar to the one described in the issue and seeing that field-presence tracking is not respected by Kafka Connect.

Open questions / Follow-ups

Should this be gate-kept by a feature flag?

Review stakeholders

@rayokota

@confluent-cla-assistant
Copy link

confluent-cla-assistant bot commented Oct 5, 2025

🎉 All Contributor License Agreements have been signed. Ready to merge.
✅ ubiquitousbyte
Please push an empty commit if you would like to re-run the checks to verify CLA status for all contributors.

@ubiquitousbyte ubiquitousbyte marked this pull request as ready for review October 5, 2025 15:18
@ubiquitousbyte ubiquitousbyte requested a review from a team as a code owner October 5, 2025 15:18
@Copilot Copilot AI review requested due to automatic review settings October 5, 2025 15:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the protobuf converter to use the hasPresence() method instead of checking for proto3Optional() when determining if a field is optional. This change addresses field-presence tracking issues in Kafka Connect when working with Protobuf messages.

  • Replaces proto3-specific optional check with a more general presence check
  • Improves field-presence handling for protobuf messages in Kafka Connect

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@rayokota
Copy link
Member

rayokota commented Oct 6, 2025

/sem-approve

@rayokota
Copy link
Member

rayokota commented Oct 7, 2025

/sem-approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants