Update kafka-run-class.bat fix for non-dev release #992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing Windows batch files on release versions that do not include dev files or gradlew builds. confluentinc#945
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing Windows batch files on release versions that do not include dev files or gradlew builds.
#945
From the 7.5.2 release zip, I am able to run bin/windows/kafka-console-consumer.bat successfully after this change. Prior to this the classpath was empty and I was prompted to run
gradlew jarAllwhich is nonsense for a release version.Committer Checklist (excluded from commit message)